This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: C++ PATCH for c++/91740 - ICE with constexpr call and ?: in ARRAY_REF

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>, Nathan Sidwell <nathan at acm dot org>
Date: Thu, 12 Sep 2019 11:03:28 +0200
Subject: Re: C++ PATCH for c++/91740 - ICE with constexpr call and ?: in ARRAY_REF
References: <20190911211527.GM14737@redhat.com>

Hi,

On 11/09/19 23:15, Marek Polacek wrote:

--- gcc/cp/pt.c
+++ gcc/cp/pt.c
@@ -26709,7 +26709,7 @@ build_non_dependent_expr (tree expr)
    if (TREE_CODE (expr) == COND_EXPR)
      return build3 (COND_EXPR,
  		   TREE_TYPE (expr),
-		   TREE_OPERAND (expr, 0),
+		   build_non_dependent_expr (TREE_OPERAND (expr, 0)),
  		   (TREE_OPERAND (expr, 1)
  		    ? build_non_dependent_expr (TREE_OPERAND (expr, 1))
  		    : build_non_dependent_expr (TREE_OPERAND (expr, 0))),

Looks like we would end up unnecessarily callingbuild_non_dependent_expr three times instead of two: probably is verycheap, probably the code is cleaner this way but I'm a little annoyed atthis anyway, for the record ;)


Cheers, Paolo.

Follow-Ups:
- Re: C++ PATCH for c++/91740 - ICE with constexpr call and ?: in ARRAY_REF
  - From: Paolo Carlini

References:
- C++ PATCH for c++/91740 - ICE with constexpr call and ?: in ARRAY_REF
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]