This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch, libgomp] Fix segfault with plugin-hsa
- From: Tobias Burnus <tobias at codesourcery dot com>
- To: <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>
- Date: Wed, 11 Sep 2019 11:30:17 +0200
- Subject: [patch, libgomp] Fix segfault with plugin-hsa
- Ironport-sdr: f8osKFnm3Id68VEGpZn+DmueB7WM/MlwGW7laZ0A+q5pJO7o2qwb/i9WNrybAzbkbLAb/w4wdh 67L+YV7ktuRu6l+6UC4MhF26rhDj5Ogte6y2iaUumDs/NZ4GvcuWEpTfaKoGibRprrjhDO/yyJ stpbjSYRKydn4lxVNxbxMMlin2kJP67c94WAsb2YP1Oid0N8eDtR0u83xIuTb2uxjIrj+wF7kJ Zi5xUwBw91EnoawXN2rcmSM6Nea+mRTfSQt09kxINgIdd72FqLAfyHgVpe2ipEx+3qC2RMKgS3 hYM=
- Ironport-sdr: 9k3FCjFcb4zaqj4elsony5uhEVukYyGpac73vkBUjLP0hxnmaacz1C5ipuYv4+jUmy6ULAdoEq dPdnaQPhdeRfQvQFWouXOAt/ldRslLbkTIOR7DBp7dO3x6QsKxcx65OY2FEQFGPn6OC8kI0zrZ rnfkzfCU+KV+q7Z8ite8+8qM/OAY10bzY7+NaabJoYYlSJYSi1Nsx9bTJdLxYWR/QcrQaXbCgi W2r7lG3jZ+dIx9opVvwBGXc0tBNAEACZeZddeImp7DqRXQfbI2SOqGnRvPKEr2NZG1Pegi+qTZ g7Y=
Hi all, hi Jakub,
when playing around with offloading, I got an hsa initialization error
(/dev/... lacked write permission) and the library call returned with an
error status – but hsa_fns.hsa_status_string_fn didn't set the message
to the string variable.
Hence, the string variable was uninitialized and libgomp crashed when
printing the error message; "[unknown]" is not the best HSA run-time
message, but at least the primary message is shown and there is no crash :-)
Build and tested on x86_64-gnu-linux.
OK for the trunk and GCC 9?
Tobias
2019-09-11 Tobias Burnus <tobias@codesourcery.com>
* plugin/plugin-hsa.c (hsa_warn, hsa_fatal, hsa_error): Ensure
string is initialized.
diff --git a/libgomp/plugin/plugin-hsa.c b/libgomp/plugin/plugin-hsa.c
index 80f23f9beb6..c0837d04e5d 100644
--- a/libgomp/plugin/plugin-hsa.c
+++ b/libgomp/plugin/plugin-hsa.c
@@ -289,7 +289,7 @@ hsa_warn (const char *str, hsa_status_t status)
if (!debug)
return;
- const char *hsa_error_msg;
+ const char *hsa_error_msg = "[unknown]";
hsa_fns.hsa_status_string_fn (status, &hsa_error_msg);
fprintf (stderr, "HSA warning: %s\nRuntime message: %s", str, hsa_error_msg);
@@ -301,7 +301,7 @@ hsa_warn (const char *str, hsa_status_t status)
static void
hsa_fatal (const char *str, hsa_status_t status)
{
- const char *hsa_error_msg;
+ const char *hsa_error_msg = "[unknown]";
hsa_fns.hsa_status_string_fn (status, &hsa_error_msg);
GOMP_PLUGIN_fatal ("HSA fatal error: %s\nRuntime message: %s", str,
hsa_error_msg);
@@ -313,7 +313,7 @@ hsa_fatal (const char *str, hsa_status_t status)
static bool
hsa_error (const char *str, hsa_status_t status)
{
- const char *hsa_error_msg;
+ const char *hsa_error_msg = "[unknown]";
hsa_fns.hsa_status_string_fn (status, &hsa_error_msg);
GOMP_PLUGIN_error ("HSA fatal error: %s\nRuntime message: %s", str,
hsa_error_msg);