This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Rename Deprecated to IgnoreWarn in *.opt files.


Jakub Jelinek <jakub@redhat.com> writes:
> On Tue, Sep 10, 2019 at 06:14:11PM +0200, Martin Liška wrote:
>> On 9/9/19 11:14 PM, Joseph Myers wrote:
>> > On Mon, 9 Sep 2019, Jakub Jelinek wrote:
>> > 
>> > > > "IgnoreWarn" reads as "ignore the warning".
>> > > > 
>> > > > If we want it named as two things, can we just make it two things?
>> > > > "Ignore WarnDeleted" or something.  Which also says what it is warning
>> > > > about.
>> > > 
>> > > Or WarnRemoved.  Both work for me, but ultimately it would be best if Joseph
>> > > decides.
>> > 
>> > I prefer WarnRemoved.
>> > 
>> 
>> Works for me. I'm going to install the tested patch.
>
> I thought the decision is to replace Deprecated with Ignore WarnRemoved
> where Ignore would handle the ignoring and WarnRemoved just add the warning
> part on top of it.  So, OPT_SPECIAL_ignore plus some flag for WarnRemoved.

Is there any time you'd use WarnRemoved without Ignore though?
Seems better not to require two flags when one would do.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]