This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH][ARM] Enable arm_legitimize_address for Thumb-2
- From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>, Kyrylo Tkachov <Kyrylo dot Tkachov at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Cc: nd <nd at arm dot com>
- Date: Mon, 9 Sep 2019 17:02:46 +0000
- Subject: [PATCH][ARM] Enable arm_legitimize_address for Thumb-2
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQa7aNvl9RxtkoDSFUXBMLQ3F95w7FMFx+265UkP3gc=; b=KsZsT7PaRkzNArfy20dVnba1V1rVOw3wu05AE0O297DLga3hbGRFXm4me+n3nhyOt/jaDX+RfrHZqNBR/Xw2fc/HbXIvHT5YcjqRtBPhWbdfICkCJZrfrT8j/cbhLFYKvGXt5EbvWXWEWWF85pDX+yA2RmMH0GZfiO3LYfJwvx24rrmLph+dw5LSvtN2vNI1BGsWDc/JjLXkpcqkeWDNPRgAFrEVcqMmVpfwyDNvtAe/pINRNU++vKn5Mji/nwXTYSpvvWpnSjL9QFdKLa7bj5ahbsezSC9fjcFSnp60TxyCXna303xuO9L57kFCOdNy+OL8/fk0/DoPRU6QUJqWfg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+P2RjKRnHcTlm1Tjl9YK7TvMVG7Bo4/hFNWLiAfIqeZXMBDPqrdxKPxq7LvXVa15uL1H8D4e6Vx2vMxHxv+Zn4l+ULdwLNR/nboj4Cdm3Xc1m39Cm33lWerqZmEz6KAAXtDHbM3/uqroR5N3KmUp8ns8Z155i+jYuegRyuIu2aam1+5PNzhWkLN1MnwjiV6Pr5VCaRr94M/ZxtdL6br+ypBw15jyPEccpg2WNk0HXmbQudmEicPhGCNjbapcGYLw67EigX2e5O5+2xU+tX/V7r9H66xMuqyo8z61gsdOJuHw1s282xNYPYL9/JfW1IPJiKbsUsQ4OqdHn0jY1TZng==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco dot Dijkstra at arm dot com;
Currently arm_legitimize_address doesn't handle Thumb-2 at all, resulting in
inefficient code. Since Thumb-2 supports similar address offsets use the Arm
legitimization code for Thumb-2 to get significant codesize and performance
gains. SPECINT2006 shows 0.4% gain on Cortex-A57, while SPECFP improves 0.2%.
Bootstrap OK, OK for commit?
ChangeLog:
2019-09-09 Wilco Dijkstra <wdijkstr@arm.com>
* config/arm/arm.c (arm_legitimize_address): Remove Thumb-2 bailout.
--
diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index a5a6a0fab1b4b7ef07931522e7d47e59842d7f27..2601708e7e0716e4668b79e015e366d2164562fd 100644
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -8652,13 +8652,8 @@ arm_legitimize_address (rtx x, rtx orig_x, machine_mode mode)
return x;
}
- if (!TARGET_ARM)
- {
- /* TODO: legitimize_address for Thumb2. */
- if (TARGET_THUMB2)
- return x;
- return thumb_legitimize_address (x, orig_x, mode);
- }
+ if (TARGET_THUMB1)
+ return thumb_legitimize_address (x, orig_x, mode);
if (GET_CODE (x) == PLUS)
{