This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Come up with json::integer_number and use it in GCOV.
- From: Martin Liška <mliska at suse dot cz>
- To: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Cc: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>
- Date: Mon, 9 Sep 2019 14:38:49 +0200
- Subject: Re: [PATCH] Come up with json::integer_number and use it in GCOV.
- References: <55b9fe0e-d2b6-6c8f-64a4-c089091ee75f@suse.cz> <1564578819.9730.24.camel@redhat.com> <0e2d2cb7-f135-78a9-d127-15273e991536@suse.cz> <1564749611.11470.7.camel@redhat.com> <21e87c50-9635-0a28-60b2-53a01661b60f@suse.cz> <fedff3d0-d85f-ce2b-8373-01376a468af0@suse.cz> <e5593b5a-69f3-82ae-8e6a-a9e0db1b13f4@suse.cz>
PING^3
On 8/30/19 10:55 AM, Martin Liška wrote:
> PING^2
>
> On 8/26/19 2:34 PM, Martin Liška wrote:
>> PING^1
>>
>> On 8/13/19 1:51 PM, Martin Liška wrote:
>>> On 8/2/19 2:40 PM, David Malcolm wrote:
>>>> Something that occurred to me reading the updated patch: maybe it would
>>>> make things easier to have utility member functions of json::object to
>>>> implicitly make the child, e.g.:
>>>>
>>>> void
>>>> json::object::set (const char *key, long v)
>>>> {
>>>> set (key, new json::integer_number (v));
>>>> }
>>>>
>>>> so that all those calls can be just:
>>>>
>>>> obj->set ("line", exploc.line);
>>>> obj->set ("column", exploc.column);
>>>>
>>>> etc (assuming overloading is unambiguous).
>>>>
>>>> But that's probably orthogonal to this patch.
>>>
>>> Looks good to me. It's a candidate for a follow up patch.
>>>
>>>>
>>>>
>>>>> And I changed all occurrences of float_number with integer_number
>>>>> as you suggested.
>>>> Thanks.
>>>>
>>>>> I'm currently testing the updated patch.
>>>>> Martin
>>>> The updated patch looks good to me, but technically I'm not a reviewer
>>>> for these files.
>>>
>>> Sure, I hope @Jakub or @Richi can approve me that?
>>> Thanks,
>>> Martin
>>>
>>>>
>>>> Dave
>>>
>>
>