This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Use cxx_printable_name for __PRETTY_FUNCTION__ in cp_fname_init.
- From: Jeff Law <law at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>, Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 3 Sep 2019 10:38:21 -0600
- Subject: Re: [PATCH] Use cxx_printable_name for __PRETTY_FUNCTION__ in cp_fname_init.
- References: <4f1b83f0-b967-c2c7-3164-7fb86e84e025@suse.cz> <13a11ba8-fd79-05ee-ddc2-f5bd393317e0@redhat.com> <0cd8a7f9-c599-2bc9-93f3-96ad0e37a5c6@suse.cz>
On 8/29/19 1:37 AM, Martin Liška wrote:
> On 8/28/19 10:19 PM, Jason Merrill wrote:
>> On 8/28/19 12:29 PM, Martin Liška wrote:
>>> The patch restores behavior before r265711 where we used
>>> cxx_printable_name for __PRETTY_FUNCTION__.
>>>
>>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>>
>>> Ready to be installed?
>>> Thanks,
>>> Martin
>>>
>>> gcc/c-family/ChangeLog:
>>>
>>> 2019-08-27 Martin Liska <mliska@suse.cz>
>>>
>>> PR c++/91155
>>> * c-common.c (fname_as_string): Use cxx_printable_name for
>>> __PRETTY_FUNCTION__ same as was used before r265711.
>>> - if (name)
>>> - free (CONST_CAST (char *, name));
>> This creates a memory leak for the fname_as_string case.
>>
>> Jason
>>
> Sure, fixed in the updated patch.
>
> Ready for trunk?
> Thanks,
> Martin
>
>
> 0001-Use-cxx_printable_name-for-__PRETTY_FUNCTION__-in-cp.patch
>
> From 528350107f256b101040bb1074006b812c052e15 Mon Sep 17 00:00:00 2001
> From: Martin Liska <mliska@suse.cz>
> Date: Tue, 27 Aug 2019 13:16:08 +0200
> Subject: [PATCH] Use cxx_printable_name for __PRETTY_FUNCTION__ in
> cp_fname_init.
>
> gcc/c-family/ChangeLog:
>
> 2019-08-27 Martin Liska <mliska@suse.cz>
>
> PR c++/91155
> * c-common.c (fname_as_string): Use cxx_printable_name for
> __PRETTY_FUNCTION__ same as was used before r265711.
>
> gcc/testsuite/ChangeLog:
>
> 2019-08-27 Martin Liska <mliska@suse.cz>
>
> PR c++/91155
> * g++.dg/torture/pr91155.C: New test.
OK
jeff