This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Go patch committed: Provide index information on bounds check failure

On Thu, Aug 29, 2019 at 1:50 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> On Aug 28 2019, Ian Lance Taylor <iant@golang.org> wrote:
>
> > This patch to the Go frontend and libgo changes the panic message
> > reported for an out of bounds index or slice operation to include the
> > invalid values.
>
> This breaks aarch64/-mabi=ilp32.
>
> aarch64-suse-linux/ilp32/libgo/archive/tar/check-testlog:
>
> /usr/aarch64-suse-linux/bin/ld: _gotest_.o: in function `archive..z2ftar.Reader.next':
> /opt/gcc/gcc-20190829/Build/aarch64-suse-linux/ilp32/libgo/gotest1086/test/reader.go:72: undefined reference to `runtime.goPanicExtendSliceAlen'

We should probably use a different GOARCH value for that build, such
as arm64p32.  But for now I'm committing this patch which will fix
both problems by just always building panic32.go.  Bootstrapped and
tested on x86_64-pc-linux-gnu.

Ian

Attachment: patch.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]