This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix bootstrap miscompare by STV (PR91580)


On Thu, 29 Aug 2019, Richard Biener wrote:

> On Thu, 29 Aug 2019, Jakub Jelinek wrote:
> 
> > On Thu, Aug 29, 2019 at 12:04:53PM +0200, Richard Biener wrote:
> > > +	else
> > 
> > Perhaps use
> > 	else if (MAY_HAVE_DEBUG_BIND_INSNS)
> > instead so that you don't walk it once again if there can't be DEBUG_INSNs?
> 
> Sure - will do as followup to unbreak bootstrap w/o re-testing this.

Bootstrapped / tested on x86_64-unknown-linux-gnu, applied.

Richard.

2019-08-29  Richard Biener  <rguenther@suse.de>

	* config/i386/i386-features.c (general_scalar_chain::convert_insn):
	Guard debug work with MAY_HAVE_DEBUG_BIND_INSNS.

Index: gcc/config/i386/i386-features.c
===================================================================
--- gcc/config/i386/i386-features.c	(revision 275030)
+++ gcc/config/i386/i386-features.c	(working copy)
@@ -893,7 +893,7 @@ general_scalar_chain::convert_insn (rtx_
 	if (use)
 	  convert_reg (insn, DF_REF_REG (ref),
 		       *defs_map.get (regno_reg_rtx [DF_REF_REGNO (ref)]));
-	else
+	else if (MAY_HAVE_DEBUG_BIND_INSNS)
 	  {
 	    /* If we generated a scalar copy we can leave debug-insns
 	       as-is, if not, we have to adjust them.  */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]