This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH V2 5/8] bpf: make target-supports.exp aware of eBPF


    > --- a/gcc/testsuite/lib/target-supports.exp
    > +++ b/gcc/testsuite/lib/target-supports.exp
    >  
    > @@ -546,7 +550,11 @@ proc check_effective_target_stack_size { } {
    >  proc dg-effective-target-value { effective_target } {
    >      if { "$effective_target" == "stack_size" } {
    >  	if [check_effective_target_stack_size] {
    > -	    return [target_info gcc,stack_size]
    > +	    if [istarget bpf-*-*] {
    > +		return "512"
    > +	    } else {
    > +		return [target_info gcc,stack_size]
    > +	    }
    >  	}
    >      }
    Shouldn't the BPF stack size be defined be in your target files?

Yes, definitely.  I am adding a board description to dejagnu.  Will
set_board_info gcc,stack_size 512 there and remove this nasty overwrite
in dg-effective-target-value.

    The ChangeLog mentions check_effective_target_malloc, but I don't see it
    in the patch itself.  Note that it needs to be documented in
    gcc/doc/sourcebuild.texi as well if you are adding a new
    check_effective_target_<whatever>

Oh at some point I introduced a check_effective_target_malloc, then
removed it.  What you saw is a stale reference in the ChangeLog.  Will
get rid of it.

Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]