This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to support extended characters in C/C++ identifiers
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Lewis Hyatt <lhyatt at gmail dot com>, <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 15 Aug 2019 12:23:07 +0000
- Subject: Re: Patch to support extended characters in C/C++ identifiers
- Ironport-sdr: 7HzQZ8a1HId8mfCRiOCWj00gDo7xACYmIq5lkqTTS5pNcb4DWPcv/QbcbNBvC6FZs8HsC9/rO4 ziNjoUoMQfmlTeZiDXgSiayILDuQrrk5mTMc76tIlw6ueqq7VJ2O+GbZyrOcSIx2TMf1ykwgJE b0Dhz+6vr9anuS8T5yFLBRVqByJlqbI6R+bGgvp3D/2hpAGh9tP1v559bfAtA+sHlxCBM4Oh/g 2eMD4DP+g1a92WJKZNV1bcBzbt5nxu13KXcBCpqluH5+H56+Pk7opduP51gT3S1XXIXu300BE+ sbY=
- Ironport-sdr: g65GfoeIJ8g8oaDBz9WpUE0dR0Ek7mYKJbgZRLXKlucGSaoSDF7qFp7Ci1AKCs/HA5iSIBQbdG 7OivmFF2IItahp+kzbT4qIe3enaqRoS/NpBEIX5F1dQHB8lGnj07j/mg25HlIGsBkiylGSazdz bezi8NQc3uhJxzOqaeYgzBPIf5/8X6gWzuyKBiDpUmdIzcjUqIW5RgbDXy4zP6TE8TW5iQAAgf xcucnct1j7vsv2hOEhJdr552uorVgRuR+4RffHtAKIgKmoFoOgX1G5ki3PctlGGKxLoI9Su9eu UOA=
- References: <20190812220121.GA9251@ldh.local> <83914efb-c81b-eb26-9799-cc7df1053af2@redhat.com>
On Thu, 15 Aug 2019, Jason Merrill wrote:
> On 8/12/19 6:01 PM, Lewis Hyatt wrote:
> > Hello-
> >
> > The attached patch for libcpp adds support for extended characters (e.g.
> > UTF-8)
> > in identifiers. A preliminary version of the patch was posted on PR c/67224
> > as
> > Comment 26 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67224#c26) and
> > discussed with Joseph Myers. Here is an updated patch incorporating all
> > feedback received so far. I hope it is suitable now; please let me know if I
> > can do anything else to make it ready for you to apply. I am happy to work
> > on
> > it further, whatever is needed. I can't easily test on anything other than
> > x86_64-linux though. I did bootstrap all languages and run all tests on that
> > platform, everything was good.
> >
> > The (relatively short) changes to libcpp are included inline here. I
> > attached
> > the test cases as a gzipped patch to avoid any problems with the encoding
> > (the
> > test cases contain some invalid UTF-8 and also other encodings such as
> > latin-1
> > as part of the testing).
> >
> > Thanks for taking a look at it!
>
> Looks good to me. Joseph?
I'm a month behind on gcc-patches at present. It will take me a while to
get to this for detailed review.
--
Joseph S. Myers
joseph@codesourcery.com