This is the mail archive of the
mailing list for the GCC project.
Re: Patch to support extended characters in C/C++ identifiers
- From: Jason Merrill <jason at redhat dot com>
- To: Lewis Hyatt <lhyatt at gmail dot com>, gcc-patches at gcc dot gnu dot org
- Cc: joseph at codesourcery dot com
- Date: Wed, 14 Aug 2019 23:48:08 -0400
- Subject: Re: Patch to support extended characters in C/C++ identifiers
- References: <20190812220121.GA9251@ldh.local>
On 8/12/19 6:01 PM, Lewis Hyatt wrote:
The attached patch for libcpp adds support for extended characters (e.g. UTF-8)
in identifiers. A preliminary version of the patch was posted on PR c/67224 as
Comment 26 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67224#c26) and
discussed with Joseph Myers. Here is an updated patch incorporating all
feedback received so far. I hope it is suitable now; please let me know if I
can do anything else to make it ready for you to apply. I am happy to work on
it further, whatever is needed. I can't easily test on anything other than
x86_64-linux though. I did bootstrap all languages and run all tests on that
platform, everything was good.
The (relatively short) changes to libcpp are included inline here. I attached
the test cases as a gzipped patch to avoid any problems with the encoding (the
test cases contain some invalid UTF-8 and also other encodings such as latin-1
as part of the testing).
Thanks for taking a look at it!
Looks good to me. Joseph?