This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Dragan Mladjenovic <dmladjenovic at wavecomp dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, Matthew Fortune <mfortune at gmail dot com>, "Maciej W . Rozycki" <macro at linux-mips dot org>, Faraz Shahbazker <fshahbazker at wavecomp dot com>
- Date: Fri, 9 Aug 2019 22:15:34 +0000
- Subject: Re: [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets.
- Ironport-sdr: jG/XDJom9r+MePMY33UHKkTu/1wgFSbBVh4hhaxkPejKJuKXKtNFKKbcjjg+/TrTqfV5x5RDLf 2rk0Fnrh/rUEFlDYGF/1ySIltaipdmz0KYe5+fnyAW/OPeRq0dtEAx8QjosdwGhA1xU7mb4awk hJK3EdsiJT4Zyk67ipDzQ+u7ffI6VFObVRLlzQOPDrHI74ELKswhamUuM+3ybdzPbVTuo2DdL+ RvTkyhSZ+UBgeC3GVmFKtqmkJspQ4zQ97JHA5TVXpcOc/nb3X1XY6WlMKtiJ24pai5gqSqzlrF UOc=
- Ironport-sdr: 3YlXR+LZY2Tvx1SNFucUuGrEcbkW5Nc3zKNw5Kwe7ztbQExTYZVul9NeGo2cCoAtUuJevR0Rl6 UldJmE1rGnmnjrrsMvsoi/QlSjLEoGVrL1hAuqh7JMgizGX35LTyRsrfoTdWpRYS3Otn/pEDFG EF4NQB6ALuVARhQ1Wgare/j1YrAs3ilxqIS02Dzr9o0/BGF7gj97z/KqCwh+4QV0MAezuqkZu2 SiM700O2bHmxVNck+UZUs73CxxKQRoQbD9bNP5vBHwksNENN0kGrLUI+XAS20I0VdRFYr3f53S q8k=
- References: <1565001657-5145-1-git-send-email-dmladjenovic@wavecomp.com> <1565002149-5397-1-git-send-email-dmladjenovic@wavecomp.com> <0da5c1c6-3146-9981-2c86-733a20e3140e@redhat.com>
On Fri, 9 Aug 2019, Jeff Law wrote:
> > 2019-08-05 Dragan Mladjenovic <dmladjenovic@wavecomp.com>
> >
> > * config.in: Regenerated.
> > * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Define to 1
> > for TARGET_LIBC_GNUSTACK.
> > * configure: Regenerated.
> > * configure.ac: Define TARGET_LIBC_GNUSTACK if glibc version is
> > found 2.31 or greater.
> My only concern here is the configure bits. So for example, will it do
> the right thing if you're cross-compiling to a MIPS linux target? If
> so, how? If not, do we need to make it a first class configure option
> so that it can be specified when building cross MIPS linux toolchains?
The key point of using GCC_GLIBC_VERSION_GTE_IFELSE is that (a) it checks
the target glibc headers if available when GCC is built and (b) if not
available, you can still use --with-glibc-version when configuring GCC, to
get the right configuration in a bootstrap compiler built before glibc is
built (the latter is necessary on some architectures to get the right
stack-protector configuration for bootstrapping glibc, but may be useful
in other cases as well).
My main concern about this patch is the one I gave in
<https://sourceware.org/ml/libc-alpha/2019-08/msg00086.html> about what
the configuration mechanism should be, on a whole-toolchain level, to say
whether you are OK with a requirement for a 4.8 or later kernel.
--
Joseph S. Myers
joseph@codesourcery.com