This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided


Christophe Lyon <christophe.lyon@linaro.org> writes:
> On Tue, 16 Jul 2019 at 12:34, Richard Sandiford
> <richard.sandiford@arm.com> wrote:
>>
>> Christophe Lyon <christophe.lyon@st.com> writes:
>> > On 22/05/2019 10:45, Christophe Lyon wrote:
>> >> On Wed, 22 May 2019 at 10:39, Szabolcs Nagy <Szabolcs.Nagy@arm.com> wrote:
>> >>>
>> >>> On 21/05/2019 16:28, Christophe Lyon wrote:
>> >>>> --- a/gcc/config/arm/linux-eabi.h
>> >>>> +++ b/gcc/config/arm/linux-eabi.h
>> >>>> @@ -89,7 +89,7 @@
>> >>>>   #define MUSL_DYNAMIC_LINKER_E "%{mbig-endian:eb}"
>> >>>>   #endif
>> >>>>   #define MUSL_DYNAMIC_LINKER \
>> >>>> -  "/lib/ld-musl-arm" MUSL_DYNAMIC_LINKER_E "%{mfloat-abi=hard:hf}.so.1"
>> >>>> +  "/lib/ld-musl-arm" MUSL_DYNAMIC_LINKER_E
>> >>>> "%{mfloat-abi=hard:hf}%{mfdpic:-fdpic}.so.1"
>> >>>
>> >>> the line break seems wrong (either needs \ or no newline)
>> >>>
>> >> Sorry, that's a mailer artifact.
>> >>
>> >>>> --- a/libsanitizer/configure.tgt
>> >>>> +++ b/libsanitizer/configure.tgt
>> >>>> @@ -45,7 +45,7 @@ case "${target}" in
>> >>>>          ;;
>> >>>>     sparc*-*-solaris2.11*)
>> >>>>          ;;
>> >>>> -  arm*-*-uclinuxfdpiceabi)
>> >>>> +  arm*-*-fdpiceabi)
>> >>>
>> >>> should be *fdpiceabi instead of *-fdpiceabi i think.
>> >>
>> >> Indeed, thanks
>> >> .
>> >>
>> > FWIW, here is the updated patch:
>> > - handles musl -fdpic suffix
>> > - disables sanitizers for arm*-*-fdpiceabi
>> > - does not handle -static in a special way, so using -static produces binaries that request the non-existing /usr/lib/ld.so.1, thus effectively making -static broken/unsupported (this does lead to a few more FAIL in the testsuite)
>> >
>> > The plan is to work -static-pie later, as discussed.
>>
>> Could you make -static without -mno-fdpic an error via a %e spec,
>> so that the failure mode is a bit more user-friendly?
>>
>
> Sure.
> Do you know if there is a way to catch linker options in the specs?
> Would it be possible to still accept -static -Wl,-dynamic-linker XXX ?

Ah, no, don't know a way of doing that.  Maybe the error isn't
feasible after all then (at least not without significant work).

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]