This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 02/10, OpenACC] Add OpenACC target kinds for decomposed kernels regions

From: Kwok Cheung Yeung <kcy at codesourcery dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: <gcc-patches at gcc dot gnu dot org>, Thomas Schwinge <thomas at codesourcery dot com>
Date: Mon, 5 Aug 2019 22:58:37 +0100
Subject: Re: [PATCH 02/10, OpenACC] Add OpenACC target kinds for decomposed kernels regions
Ironport-sdr: K3ojQcK4oDHU+KQA3zBMZeH+EYz+W+cWJRUys3/cR6Wor8WmKOC2Z1xpRL0tGh2VhYn99Ks6sU hdydd3DtpvspxSSKfJdJIXZKWTV4kShVD9i2OIf4CLtu7/1qn4Yy9z1bwfCcuGB7nvVxrXkrpx Lg9qwl4AG8PgVpJOy932x/BfS3y0BHVKm5pgXD5xRT5Nb6fqc16uf26+XFoRt791CHpPyORSkn yp2NYOP7aXIoKp60saq10A+wD8bkOUaN1K0pUX26S1V1CYmAUjpMVyMaiMBZa7/xqzbCPNuEp4 f+E=
Ironport-sdr: Hw2apEY+YC3fQOD875A69OwOzUVbFRz1TlDjbXSsUHUwjkqlc+GJCtg/iwcV3/7fcATVB1ATg6 5y0pQzGCCwhubwaqEn9bCH/tj6dUQrg7zVhk/7+plKoec3i8xe/miUkx9AeJKSemA+zzjlokBm MaSOuPV3t36RdzQDKWmym4XQjlaNdgpuyuSqsnX+jCEh2kgJYDra0H1aIfsl8xGPw9KmmdeACk SlwLUOSyuVEEvbZduchmv/e8bVMRH03j2jUxVIAj4KZCz6baTbz7X9SLUzSop+2sVsjBrYp+V4 khg=
References: <5e191259-d5d5-34ce-7fd5-fc8d2e6d982e@codesourcery.com> <b305f639-9850-e46c-9f7b-302c1a444915@codesourcery.com> <20190718092435.GM2125@tucnak>

I have run the whole patch series through check_GNU_style.sh and fixedup the formatting where indicated. Do I need to post the reformattedpatchset?


Thanks

Kwok

On 18/07/2019 10:24 am, Jakub Jelinek wrote:

On Wed, Jul 17, 2019 at 10:04:10PM +0100, Kwok Cheung Yeung wrote:

@@ -2319,7 +2339,8 @@ scan_omp_for (gomp_for *stmt, omp_context *outer_ctx)
      {
        omp_context *tgt = enclosing_target_ctx (outer_ctx);

-      if (!tgt || is_oacc_parallel (tgt))
+      if (!tgt || (is_oacc_parallel (tgt)
+                    && !was_originally_oacc_kernels (tgt)))
  	for (tree c = clauses; c; c = OMP_CLAUSE_CHAIN (c))
  	  {
  	    char const *check = NULL;


Please watch up formatting, the above doesn't use tabs where it should.
Have you run the series through contrib/check_GNU_style.sh ?

Otherwise, no concerns about this particular patch, assuming Thomas is ok
with it.

	Jakub

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]