This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Teach mklog to reference PRs.

On 8/2/19 10:54 AM, Jakub Jelinek wrote:
> On Fri, Aug 02, 2019 at 10:48:55AM +0200, Martin Liška wrote:
>>> Just a nit, some lines are too long and perhaps mklog could be improved too.
>>> On the first line above, one would normally wrap it as:
>>> 	* testsuite/23_containers/array/comparison_operators/
>>> 	New test.
>>> and on the last line above
>>> 	* testsuite/25_algorithms/copy_backward/move_iterators/
>>> 	(test01):
>>> 	Jakub
>> Good idea. What limit are we targeting in ChangeLog entries? 60 chars?
> I think 80 chars including the 8 for the initial tab, excluding newline.
> Of course, there are sometimes especially in libstdc++-v3 filenames that
> are longer and we don't want to wrap in the middle of a filename, in that
> case we just go over the limit, but if we can wrap somewhere (in the space
> before (, or after : ) and the line is too long, we should (or even could
> wrap as
> 	* ............................................................: New
> 	test.
> ).
> 	Jakub

Ah ok, I'm leaving that for the future right now as a small improvement.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]