This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)

From: "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>
To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>, Richard Biener <rguenther at suse dot de>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, Eric Botcazou <ebotcazou at adacore dot com>
Date: Fri, 2 Aug 2019 10:10:14 +0100
Subject: Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)
References: <AM6PR07MB4037775DF79E0229DCCA425AE44F0@AM6PR07MB4037.eurprd07.prod.outlook.com> <alpine.LSU.2.20.1903211208070.4934@zhemvz.fhfr.qr> <AM6PR07MB403745E0BCCCF005A02B0CBDE4430@AM6PR07MB4037.eurprd07.prod.outlook.com> <alpine.LSU.2.20.1903250937530.4934@zhemvz.fhfr.qr> <AM6PR10MB256664D731C3CC92F2FBEDC5E4DC0@AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM> <3da1f037-f060-87ca-36ed-93c2ab73e620@arm.com> <AM6PR10MB25663B83FF44D77F57CC4375E4DE0@AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM>

On 01/08/2019 12:19, Bernd Edlinger wrote:

On 7/31/19 3:16 PM, Richard Earnshaw (lists) wrote:



On 30/07/2019 21:51, Bernd Edlinger wrote:

+/* { dg-options "-marm -march=armv6 -mno-unaligned-access -mfloat-abi=soft -mabi=aapcs -O3" } */


This isn't going to work as-is, we test many combinations of the compiler, either with explicit dejagnu settings or with the compiler defaults and the dejagnu settings can't generally be overridden this way.

For -marm you require an effective-target of arm_arm_ok.  For ldrd, it should be enough to just require an effective-target of arm_ldrd_strd_ok, then you can .

I don't think we really care about any ABIs other than aapcs, so I'd just leave that off.  And as for setting the float-abi, I don't see anything in the tests that would require that, so that can probably be omitted as well.

I think with all this, you can then write something like

/* { dg-require-effective-target arm_arm_ok && arm_ldrd_strd_ok } */
/* { dg-options "-marm -mno-unaligned-access -O3 } */

But I haven't tested that, so you might need to fiddle with it a bit, especially the effective-target rule.


Okay, it seems we need two dg-require-effective-target rules for this to work,
as in the attached new version of the patch which I am currently boot-strapping.

Is it OK for trunk after successful boot-strap and reg-testing?

The tests are OK. If the match rules for the stm instruction turn outto cause problems I think we can just drop them without materiallyweakening the tests. But lets wait and see on that.


I'll leave the mid-end bits to Richi, I'm not familiar with that code.

R.


Thanks
Bernd.

References:
- Re: [PATCHv3] Fix not 8-byte aligned ldrd/strd on ARMv5 (PR 89544)
  - From: Bernd Edlinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]