This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Properly detect working jobserver in gcc driver.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org, Michael Matz <matz at suse dot de>, Richard Biener <richard dot guenther at gmail dot com>
- Date: Thu, 1 Aug 2019 16:41:26 +0200
- Subject: Re: [PATCH] Properly detect working jobserver in gcc driver.
- References: <20190731073407.GU15878@tucnak> <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <20190731085757.GX15878@tucnak> <email@example.com> <firstname.lastname@example.org> <email@example.com> <20190801131932.GA2726@tucnak> <firstname.lastname@example.org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Aug 01, 2019 at 04:34:09PM +0200, Martin Liška wrote:
> Ok, after deeper discussion with Honza, I would like to suggest the original
> patch that was about proper detection of jobserver.
> Can you please Jakub test the patch in your environment?
Isn't this done too late (as in, doesn't the driver at that moment already
have some files newly openend, like e.g. the @ option files?
> + = ((sscanf (n, "--jobserver-auth=%d,%d", &rfd, &wfd) == 2)
No need to wrap sscanf (...) == 2 into ()s. Also, you've already done
a strstr, what is the point in verifying it once again that it starts with
And in the lto-writer.c code there is no space between sscanf and (.