This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix simd attribute handling on aarch64 (version 2)


Steve Ellcey <sellcey@marvell.com> writes:
> On Tue, 2019-07-30 at 14:31 +0100, Richard Sandiford wrote:
>> 
>> > -
>> > -      tree new_type = build_distinct_type_copy (TREE_TYPE (node-
>> > >decl));
>> > -      TYPE_ARG_TYPES (new_type) = new_reversed;
>> 
>> I think you still need this line, just applied to the existing type
>> rather than a new one.
>> 
>> > -      TREE_TYPE (node->decl) = new_type;
>> > -
>> >        adjustments.release ();
>> >      }
>
> OK, I fixed that and retested with no regressions.
>
> Steve Ellcey
> sellcey@marvell.com
>
>
> 2019-07-30  Steve Ellcey  <sellcey@marvell.com>
>
> 	* omp-simd-clone.c (simd_clone_adjust_return_type): Remove call to
> 	build_distinct_type_copy.
> 	(simd_clone_adjust_argument_types): Ditto.
> 	(simd_clone_adjust): Call build_distinct_type_copy here.
> 	(expand_simd_clones): Ditto.
>
> 2019-07-30  Steve Ellcey  <sellcey@marvell.com>
>
> 	* gcc.target/aarch64/simd_pcs_attribute.c: New test.
> 	* gcc.target/aarch64/simd_pcs_attribute-2.c: Ditto.
> 	* gcc.target/aarch64/simd_pcs_attribute-3.c: Ditto.

OK if there are no objections in 48 hours.

Thanks,
Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]