This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Do not emit __gnu_lto_v1 symbol.
- From: Martin Liška <mliska at suse dot cz>
- To: Georg-Johann Lay <avr at gjlay dot de>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 30 Jul 2019 09:48:02 +0200
- Subject: Re: [PATCH] Do not emit __gnu_lto_v1 symbol.
- References: <5D3EF8CD.10200@gjlay.de>
On 7/29/19 3:46 PM, Georg-Johann Lay wrote:
> Hi Martin.
>
> In SVN r273662 you changed a comment in avr.c from __gnu_lto_v1 to __gnu_lto_slim without changing the relevant code:
Yes.
>
> /* __gnu_lto_slim is just a marker for the linker injected by toplev.c.
> There is no need to trigger __do_clear_bss code for them. */
>
> if (!STR_PREFIX_P (name, "__gnu_lto"))
> avr_need_clear_bss_p = true;
Because now, the only symbol that starts with __gnu_lto is __gnu_lto_slim. That's why I adjusted
the comment only to reflect reality.
>
> This means that just defining symbol __gnu_lto_slim will trigger code from libgcc (code to clear .bss, which is supposed to be conditional depending on whether .bss actually contains anything).
>
> Would you also adjust that test?
>
> Thanks,
>
> Johann
>