This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR91195: fix -Wmaybe-uninitialized warning for conditional store optimization
- From: Jeff Law <law at redhat dot com>
- To: JiangNing OS <jiangning at os dot amperecomputing dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 24 Jul 2019 09:47:52 -0600
- Subject: Re: [PATCH] PR91195: fix -Wmaybe-uninitialized warning for conditional store optimization
- References: <MN2PR01MB5424AEF5B753FFAEB6FEB00E9CC70@MN2PR01MB5424.prod.exchangelabs.com>
On 7/22/19 10:26 PM, JiangNing OS wrote:
> This patch is to fix PR91195. Is it OK for trunk?
>
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog
> index 711a31ea597..4db36644160 100644
> --- a/gcc/ChangeLog
> +++ b/gcc/ChangeLog
> @@ -1,3 +1,9 @@
> +2019-07-22 Jiangning Liu <jiangning.liu@amperecomputing.com>
> +
> + PR middle-end/91195
> + * tree-ssa-phiopt.c (cond_store_replacement): Work around
> + -Wmaybe-uninitialized warning.
I'll conditionally OK this for the trunk. Give Richi 48hrs to chime in
if he doesn't like the TREE_NO_WARNING approach.
For anyone watching the thread, the setting of TREE_NO_WARNING here is
only done in those cases where we haven't already seen a dominating
memory reference, so it minimizes how often we set TREE_NO_WARNING.
jeff