This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ARM][PATCH 1/2] Support HFmode for standard names implemented with VRINT instructions.


Hi,


Pinging for review of https://gcc.gnu.org/ml/gcc-patches/2019-05/msg01921.html.


Regards,

SRI.

________________________________
From: gcc-patches-owner@gcc.gnu.org<mailto:gcc-patches-owner@gcc.gnu.org> <gcc-patches-owner@gcc.gnu.org><mailto:gcc-patches-owner@gcc.gnu.org> on behalf of Srinath Parvathaneni <Srinath.Parvathaneni@arm.com><mailto:Srinath.Parvathaneni@arm.com>
Sent: 29 May 2019 15:47:59
To: gcc-patches@gcc.gnu.org<mailto:gcc-patches@gcc.gnu.org> <gcc-patches@gcc.gnu.org><mailto:gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com><mailto:nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com><mailto:Richard.Earnshaw@arm.com>; Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com><mailto:Ramana.Radhakrishnan@arm.com>; Kyrylo Tkachov <Kyrylo.Tkachov@arm.com><mailto:Kyrylo.Tkachov@arm.com>
Subject: [ARM][PATCH 1/2] Support HFmode for standard names implemented with VRINT instructions.

Hello,

The initial implementation of the FP16 extension added HFmode support to
a limited number of the standard names.  Following
https://gcc.gnu.org/ml/gcc-patches/2016-08/msg00168.html , this patch
extends the HFmode support to the names implemented by the ARM
<vrint_pattern> and l<vrint_pattern> expanders: btrunc, ceil, round,
floor, nearbyint and rint. This patch also changes the patterns
supporting the neon_vrnd* and neon_vcvt* Adv.SIMD intrinsics to use the
standard names, where apropriate.

No new tests are added. The ARM tests for the SF and DF mode variants of
these names are based on GCC builtin functions and there doesn't seem to
be an obvious alternative to trigger the new patterns through the
standard names. The pattern definitions though are tested through the
Adv.SIMD intrinsics.

The following patch reworks the implementation for HFmode VRINT to
remove a number of redundant constructs that were added in the initial
implementation.

The two patches have been tested for arm-none-linux-gnueabihf with
native bootstrap and make check and for arm-none-eabi with
cross-compiled check-gcc on an ARMv8.4-A emulator.

Ok for trunk? If ok, could someone please commit the patch on my behalf,
I don't have commit rights.

2019-05-29 Srinath Parvathaneni <srinath.parvathaneni@arm.com><mailto:srinath.parvathaneni@arm.com>
           Matthew Wahab  <matthew.wahab@arm.com><mailto:matthew.wahab@arm.com>

        * config/arm/iterators.md (fp16_rnd_str): Replace UNSPEC_VRND
        values with equivalent UNSPEC_VRINT values.  Add UNSPEC_NVRINTZ,
        UNSPEC_NVRINTA, UNSPEC_NVRINTM, UNSPEC_NVRINTN, UNSPEC_NVRINTP,
        UNSPEC_NVRINTX.
        (vrint_variant): Fix some white-space.
        (vrint_predicable): Fix some white-space.
        * config/arm/neon.md (neon_v<fp16_rnd_str><mode>): Replace
        FP16_RND iterator with NEON_VRINT and update the rest of the
        pattern accordingly.
        (neon_vcvt<vcvth_op><sup><mode>): Replace with
        neon_vcvt<nvrint_variant><su><mode>.
        (neon_vcvt<nvrint_variant><su><mode>): New.
        (neon_vcvtn<su><mode>): New.
        * config/arm/unspecs.md: Add UNSPEC_VRINTN.
        * config/arm/vfp.md (neon_v<fp16_rnd_str>hf): Convert to an
        expander invoking <vrint_pattern>hf2.
        (neon_vrndihf): Remove.
        (neon_vrndnhf): New.
        (neon_vcvt<vcvth_op>h<sup>si): Remove.
        (<vrint_pattern>hf2): New.
        (l<vrint_pattern><su_optab>hfsi2): New.
        (neon_vcvt<vrint_variant>h<su>si): New.
        (neon_vcvtnh<su>si): New.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]