This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Go patch committed: Follow-on fix for finalizing imported methods


This Go frontend patch by Than McIntosh is a revision to
https://golang.org/cl/185518
(https://gcc.gnu.org/ml/gcc-patches/2019-07/msg00821.html), which
added code to perform finalization of methods on types created by the
importer and not directly reachable until inlining is done.

The original fix invoked the finalization code at the end of
Import::read_types(), but it turns out this doesn't handle the case
where a type with methods is read in due to a reference from something
later in the export data (a function or variable).  The fix is to move
the import finalization call to the end of Import::import().

A testcase for this bug is in https://golang.org/cl/187057.

This fixes https://golang.org/issue/33219.

Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu.  Committed
to mainline.

Ian

Attachment: patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]