This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH, i386]: Remove *qi_2_slp insn patterns


These insn patterns are just too complex to ever match. Remove them.

2019-07-18  Uroš Bizjak  <ubizjak@gmail.com>

    * config/i386/i386.md (*addqi_2_slp): Remove.
    (*<code>qi_2_slp): Ditto.

Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.

Committed to mainline SVN.

For the reference, the correct form would be:

--cut here--
(define_insn "*and<mode>_2_slp"
  [(set (reg FLAGS_REG)
    (compare
      (and:SWI12 (match_operand:SWI12 1 "nonimmediate_operand" "%0")
             (match_operand:SWI12 2 "general_operand" "<r>mn"))
      (const_int 0)))
   (set (strict_low_part (match_operand:SWI12 0 "register_operand" "+<r>"))
    (and:SWI12 (match_dup 1) (match_dup 2)))]
  "(!TARGET_PARTIAL_REG_STALL || optimize_function_for_size_p (cfun))
   && ix86_match_ccmode (insn, CCNOmode)
   /* FIXME: without this LRA can't reload this pattern, see PR82524.  */
   && (rtx_equal_p (operands[0], operands[1])
       || rtx_equal_p (operands[0], operands[2]))"
  "and{<imodesuffix>}\t{%2, %0|%0, %2}"
  [(set_attr "type" "alu")
   (set_attr "mode" "<MODE>")])

(define_insn "*<code><mode>_2_slp"
  [(set (reg FLAGS_REG)
    (compare
      (any_or:SWI12 (match_operand:SWI12 1 "nonimmediate_operand" "%0")
            (match_operand:SWI12 2 "general_operand" "<r>mn"))
      (const_int 0)))
   (set (strict_low_part (match_operand:SWI12 0 "register_operand" "+<r>"))
    (any_or:SWI12 (match_dup 1) (match_dup 2)))]
  "(!TARGET_PARTIAL_REG_STALL || optimize_function_for_size_p (cfun))
   && ix86_match_ccmode (insn, CCNOmode)
   /* FIXME: without this LRA can't reload this pattern, see PR82524.  */
   && (rtx_equal_p (operands[0], operands[1])
       || rtx_equal_p (operands[0], operands[2]))"
  "<logic>{<imodesuffix>}\t{%2, %0|%0, %2}"
  [(set_attr "type" "alu")
   (set_attr "mode" "<MODE>")])
--cut here--

Uros.

Attachment: p.diff.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]