Re: PR90723

[Prathamesh Kulkarni <prathamesh dot kulkarni at linaro dot org>]

On Thu, 11 Jul 2019 at 13:39, Richard Sandiford
<richard.sandiford@arm.com> wrote:
>
> Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org> writes:
> > @@ -186,6 +186,23 @@ skip_alternative (const char *p)
> >  /* Nonzero means volatile operands are recognized.  */
> >  extern int volatile_ok;
> >
> > +/* RAII class for temporarily setting volatile_ok.  */
> > +
> > +class temporary_volatile_ok
> > +{
> > +public:
> > +  temporary_volatile_ok (int value): save_volatile_ok (volatile_ok)
>
> Missing space before the ":".
>
> > +  {
> > +    volatile_ok = value;
> > +  }
> > +
> > +  ~temporary_volatile_ok () { volatile_ok = save_volatile_ok; }
> > +
> > +private:
> > +  temporary_volatile_ok (const temporary_volatile_ok&);
>
> Missing space before the "&".
Oops, sorry about that.
>
> OK with those changes, thanks.
Thanks, committed as r273466.

Thanks,
Prathamesh
>
> Richard
>
>
> > +  int save_volatile_ok;
> > +};
> > +
> >  /* Set by constrain_operands to the number of the alternative that
> >     matched.  */
> >  extern int which_alternative;