This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)
- From: Jeff Law <law at redhat dot com>
- To: Andrew Pinski <pinskia at gmail dot com>, JiangNing OS <jiangning at os dot amperecomputing dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 12 Jul 2019 10:05:49 -0600
- Subject: Re: [PATCH] improve ifcvt optimization (PR rtl-optimization/89430)
- References: <BL0PR0102MB3588BB0559DF4ECE564C898C9C440@BL0PR0102MB3588.prod.exchangelabs.com> <email@example.com> <MN2PR01MB5424C6D5A75618BCD71DF68E9CE40@MN2PR01MB5424.prod.exchangelabs.com> <firstname.lastname@example.org> <CAFiYyc2XD=tfM--7BMnHa_t2Bz2Xi3ORqOWyGoBNWW_-3kBG0g@mail.gmail.com> <email@example.com> <MN2PR01MB54243464065FC39D222E44139CF60@MN2PR01MB5424.prod.exchangelabs.com> <CA+=Sn1mcpxv7YYq48rrYvG-Sm-0F3ROhNy=1fD17A7KwjvLcMg@mail.gmail.com>
On 7/11/19 10:08 PM, Andrew Pinski wrote:
> On Mon, Jul 8, 2019 at 12:39 AM JiangNing OS
> <firstname.lastname@example.org> wrote:
>> Hi Jeff and Richard B.,
>> Following your tips, I've found a much simpler solution in tree-ssa-phiopt.c. Attached is the new patch. Review again, please!
> /* Prove that we can move the store down. We could also check
> TREE_THIS_NOTRAP here, but in that case we also could move stores,
> whose value is not available readily, which we want to avoid. */
> I think the comment above the change needs to be changed or extended slightly.
Actually, I don't think that comment needs to change. But the one
before cond_store_replacement needs minor updating which I'll take care of.
My reasoning is that addressables in the local stack are most likely
going to already have their lines in the cache and thus are available