This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add hints for slim dumping if fallthrough bb of jump isn't next bb


Kewen.Lin <linkw@linux.ibm.com> writes:
> +             /* Emit a hint if the fallthrough target of current basic block
> +                isn't the one placed right next.  */
> +             else if (EDGE_COUNT (bb->succs) > 0)
> +               {
> +                 gcc_assert (BB_END (bb) == tmp_rtx);
> +                 const rtx_insn *ninsn = NEXT_INSN (tmp_rtx);
> +                 /* Bypass intervening deleted-insn notes and debug insns.  */
> +                 while (ninsn && !NONDEBUG_INSN_P (ninsn)
> +                        && !start[INSN_UID (ninsn)])

Just a cosmetic thing, but when the full expression needs to be split
over several lines, there should be one condition per line:

		 while (ninsn
			&& !NONDEBUG_INSN_P (ninsn)
			&& !start[INSN_UID (ninsn)])

OK with that change, thanks.

Richard

> +                   ninsn = NEXT_INSN (ninsn);
> +                 edge e = find_fallthru_edge (bb->succs);
> +                 if (e && ninsn)
> +                   {
> +                     basic_block dest = e->dest;
> +                     if (start[INSN_UID (ninsn)] != dest)
> +                       fprintf (outf, "%s      ; pc falls through to BB %d\n",
> +                                print_rtx_head, dest->index);
> +                   }
> +               }
>             }
>         }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]