This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH], PowerPC, Patch #7, Split up SIGNED_34BIT and SIGNED_16BIT macros


On Tue, Jul 09, 2019 at 07:46:26PM -0400, Michael Meissner wrote:
> This patch splits up the macros SIGNED_16BIT_OFFSET_P and SIGNED_34BIT_OFFSET_P
> into two separate macros as you asked for previously in private mail.  The main
> macros:
> 
> 	SIGNED_16BIT_OFFSET_P
> 	SIGNED_34BIT_OFFSET_P
> 
> only take one argument, and that is the offset that is being tested.  The new
> macros:
> 
> 	SIGNED_16BIT_OFFSET_EXTRA_P
> 	SIGNED_34BIT_OFFSET_EXTRA_P
> 
> Retain the two arguments that the current macros have.  It is useful when the
> functions that are validating addresses that might be split (such as the two
> doubles in __ibm128) to verify that all addresses in the range of offset to
> offset + extra are valid 16 or 34-bit offsets.  I have changed the existing
> uses of these macros.

This is okay for trunk.  Thanks Mike.


Segher


> 	* config/rs6000/predicates.md (cint34_operand): Update
> 	SIGNED_34BIT_OFFSET_P call.
> 	(pcrel_address): Update SIGNED_34BIT_OFFSET_P call.
> 	(pcrel_external_address): Update SIGNED_34BIT_OFFSET_P call.
> 	* config/rs6000/rs6000.c (rs6000_prefixed_address): Update
> 	SIGNED_16BIT_OFFSET_P and SIGNED_34BIT_OFFSET_P calls.
> 	* config/rs6000/rs6000.h (SIGNED_16BIT_OFFSET_P): Remove EXTRA
> 	argument.
> 	(SIGNED_34BIT_OFFSET_P): Remove EXTRA argument.
> 	(SIGNED_16BIT_OFFSET_EXTRA_P): New macro, like
> 	SIGNED_16BIT_OFFSET_P with an EXTRA argument.
> 	(SIGNED_34BIT_OFFSET_EXTRA_P): New macro, like
> 	SIGNED_34BIT_OFFSET_P with an EXTRA argument.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]