This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITTED] Turn of ipa-ra in builtins test (PR91059)


On Mon, 8 Jul 2019, Wilco Dijkstra wrote:

> The gcc.c-torture/execute/builtins/lib directory contains a reimplementation
> of many C library string functions, which causes non-trivial register allocation
> bugs with LTO and static linked libraries.  To fix this long-standing test issue,
> turn off ipa-ra which avoids the register corruption across calls.  All builtin
> torture tests now pass on aarch64-none-elf.  Committed as obvious.

Would have been nice if the above text also mentioned that PR 78527 has some
background info for the "obvious".  The paragraph went into commit text, but on
its own it doesn't explain what's "obvious" here at all :(

(went looking for the explanation after collecting jaw from the floor; I don't
agree with triage shown there, but what does it matter...)

> ChangeLog:
> 2019-07-08  Wilco Dijkstra  <wdijkstr@arm.com>
> 
> testsuite/
> 	PR testsuite/91059
> 	PR testsuite/78529
> 	* gcc.c-torture/execute/builtins/builtins.exp: Add -fno-ipa-ra.

Alexander


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]