This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix ODR violations in code using <ext/atomicity.h>
- From: Daniel Krügler <daniel dot kruegler at gmail dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: Nathan Sidwell <nathan at acm dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 5 Jul 2019 20:23:40 +0200
- Subject: Re: [PATCH] Fix ODR violations in code using <ext/atomicity.h>
- References: <20190621160152.GN7627@redhat.com> <email@example.com> <20190621170816.GO7627@redhat.com> <20190621171304.GP7627@redhat.com> <20190705161325.GV4665@redhat.com>
Am Fr., 5. Juli 2019 um 18:13 Uhr schrieb Jonathan Wakely <firstname.lastname@example.org>:
> I decided against the simplification in the second patch, and
> committed the attached one which is closer to the first patch I sent
> (preserving the __atomic_add and __exchange_and_add functions even
> when they just call the built-ins).
> Tested x86_64-linux, powerpc64-linux, powerpc-aix. Committed to trunk.
Unrelated to the actual patch, I noticed some explicit "throw()" forms
used as exception specifications - shouldn't these be replaced by
either explicit "noexcept" or at least by a library macro that expands
to one or the other? (I'm sorry, if such unrelated questions are
considered as inappropriate for this list).