This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] simplify-rtx.c: Change BITSIZE to UNIT_PRECISION in simplification


On Wed, Jul 03, 2019 at 04:32:54PM -0600, Jeff Law wrote:

     John, I assume you're doing this for an out of tree port (s12z?)?

That is correct.

     Otherwise it'd also be useful if you could include a test which triggers
     the assert.

Once I have the other aspects of the port sorted out I can create a test
case (although it wouldn't be necessary because it happens building
libgcc).
     
     If you could confirm that Richard's suggestion of using
     GET_MODE_PRECISION rather than GET_MODE_UNIT_PRECISION works it'd be
     appreciated.

I had wondered about the difference between the two.   Unfortunately, 
neither are mentioned in gccint.texinfo   - I ended up deciding upon
GET_MOE_UNIT_PRECISION because there is a similar situation a few lines
above in simplify-rtx.c which uses it.   

If GET_MODE_UNIT_PRECISION is inappropriate, then please change it.


Regards,

John

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]