This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Come up with function_decl_type and use it in tree_function_decl.


On 7/2/19 5:49 AM, Martin Liška wrote:
Hi.

After the discussion with Richi and Nathan, I made a place in tree_function_decl
and I rebased the original Dominik's patch on top of that.

Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

FWIW, I think there is a choice between using the convention to end
names of a predicate in _P and between using _IS_ in the predicate
name.  E.g., DECL_P or CALL_P, vs DECL_IS_BUILTIN, or
CLASSTYPE_IS_TEMPLATE.  There are a handful of examples that use
both _IS_ and _P but those are in minority, so I would suggest to
choose one or the other (but not both) for new names.

Martin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]