This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Reimplement GNU threads library on native Windows
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Tue, 2 Jul 2019 12:56:32 +0100
- Subject: Re: [patch] Reimplement GNU threads library on native Windows
- References: <2175092.5hV0XgF4mA@polaris> <3776452.kYZe2UzrzK@polaris> <20190702094535.GG4665@redhat.com> <2137325.3ljLlHVGes@polaris>
On 02/07/19 11:54 +0200, Eric Botcazou wrote:
Yes there are definitely still references to C++0x elsewhere in
libstdc++, especially in the testsuite, but let's not add new ones.
It's libgcc though, not libstdc++. And it's a bit inconvenient to have c++0x
on the one hand (gthr.h) and c++11 on the other hand (gthr-win32-thread.c); in
other words, consistency matters too.
Then I think we go with the attached patch to rename everything. This
could break out-of-tree ports that define __GTHREADS_CXX0X, if there
are any. We could consider making gthr.h do this after including
gthr-default.h:
#if defined __GTHREADS_CXX0X && ! defined __GTHREADS_CXX11
# warning "Define __GTHREADS_CXX11 instead of __GTHREADS_CXX0X"
# define __GTHREADS_CXX11 1
#endif