This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][aarch64]: fix unrecognizable insn for ldr got in ilp32 tiny


Hi Silvia,

> Combined them into one pattern. Updated the diff and the changelog is now:
 
 gcc/ChangeLog:
 
 2019-06-18  Sylvia Taylor  <sylvia.taylor@arm.com>
 
         * config/aarch64/aarch64.c
         (aarch64_load_symref_appropriately): Change SYMBOL_TINY_GOT.
         * config/aarch64/aarch64.md
         (ldr_got_tiny_<mode>): New pattern.
         (ldr_got_tiny_sidi): New pattern.
 

Thanks, this looks fine to me, but I can't approve. 

As an aside there is an inconsistency in the mode used for symbols throughout
aarch64.md. Some have no mode, others use PTR, and some cases use DI mode
(which means ILP32 may want SImode for some symbols and DImode in other cases...).
Since various existing patterns have this issue it's not a problem with this patch.

Wilco
     

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]