This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [MIPS] Fix for the wrong argument sequence in MSA builtin for FMADD/MADDV family.
- From: Jeff Law <law at redhat dot com>
- To: Dragan Mladjenovic <dmladjenovic at wavecomp dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Matthew Fortune <mfortune at gmail dot com>
- Date: Fri, 31 May 2019 15:41:35 -0600
- Subject: Re: [MIPS] Fix for the wrong argument sequence in MSA builtin for FMADD/MADDV family.
- References: <1558505597-7726-1-git-send-email-dmladjenovic@wavecomp.com>
On 5/22/19 12:13 AM, Dragan Mladjenovic wrote:
> Hi all,
>
> This patch makes the behavior of __builtin_msa_ fmadd/fmsub/maddv match the
> expected one. While not a recent regression, it would be nice if this can
> be back-ported in order to minimize the fragmentation.
>
> Best regards,
>
> Dragan
>
> gcc/ChangeLog:
>
> 2019-05-20 Prachi Godbole <prachi.godbole@imgtec.com>
> Robert Suchanek <robert.suchanek@mips.com>
>
> * gcc/config/mips/mips.c (mips_expand_builtin_insn): Swap the 1st
> and 3rd operands of the fmadd/fmsub/maddv builtin.
>
> gcc/testsuite/ChangeLog:
>
> 2019-05-20 Dragan Mladjenovic <dmladjenovic@wavecomp.com>
>
> * gcc.target/mips/msa-fmadd.c: New.
THanks. I've installed this one the trunk.
Out of an abundance of caution I have not installed it on any of the
release branches. Feel free to ping me in a week or so and if there
haven't been any issues I'll back port it.
jeff