Re: libbacktrace tests for AIX

[Tom de Vries <tdevries at suse dot de>]

[ Add CC gcc-patches ]

On 23-05-19 15:22, CHIGOT, CLEMENT wrote:
> Hi Ian, Tom, 
> 
> I've some problems with gccgo and libbacktrace so I've tried to run
> libbacktrace tests on AIX, to see if everything looks good. 
> However, I can't build them... 
> 
> Looking at the code, test_elf is trying to compile elf.c which won't
> work because BACKTRACE_ELF_SIZE is defined to unused. Therefore, I've
> got this error:
>     ../../../../gcc-9.1.0/libbacktrace/elf.c:144:2: error: #error
> "Unknown BACKTRACE_ELF_SIZE"
>     144 | #error "Unknown BACKTRACE_ELF_SIZE"
>         |  ^~~~~
>  
> On a elf system (I've tried on Fedora), test_xcoff is separated into two
> different tests: *test_xcoff_32 and test_xcoff_64*. These tests will
> build xcoff_32.c and xcoff_64.c replacing BACKTRACE_XCOFF_SIZE by the
> correct value. 
> 
> I was wondering if it's possible to do something similar for test_elf ? 

Hi,

I think so, yes.

> I've tried locally on AIX and it seems to work. I haven't tried on
> Fedora yet, but I don't see any reason why it would fail. 
> 
> If you agree with that, I'll submit a patch (to you by the way?). 
> 

Fine by me. Please send to both Ian and me, as well as
gcc-patches@gcc.gnu.org.

Thanks,
- Tom