This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] aarch64 back-end changes


On 15/05/2019 13:48, Richard Earnshaw (lists) wrote:
> On 15/05/2019 03:39, kugan.vivekanandarajah@linaro.org wrote:
>> From: Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org>
>>
> 
> The subject line to this email is not helpful.  Why should I be
> interested in reviewing this patch?  Also, why does it claim to be 2/2
> when there's no 1/2 to go with it?

Ah, just noticed that there is a part 1/2 (and a part 0/2) but they hit
a different filter in my mailer so ended up in a different folder.  That
doesn't affect the other comments, though: each patch should be
self-contained, even if there's an overall covering letter.

R.

> 
> Please include with all patches a justification giving background to why
> you believe the patch is correct.  All patches need this sort of
> description - don't assume that the reviewer is familiar with the code
> or will just accept your word for it.
> 
> R.
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]