This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: C++ PATCH for c++/78010 - bogus -Wsuggest-override warning on final function

From: Jason Merrill <jason at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 10 May 2019 10:45:54 -0400
Subject: Re: C++ PATCH for c++/78010 - bogus -Wsuggest-override warning on final function
References: <20190506210718.GG4334@redhat.com>

On 5/6/19 5:07 PM, Marek Polacek wrote:

-Wsuggest-override warns for virtual functions that could use the override
keyword.  But as everyone in this PR agrees, the warning shouldn't suggest
adding "override" for "final" functions.  This trivial patch implements that.

Bootstrapped/regtested on x86_64-linux, ok for trunk/9?


OK.

Jason

References:
- C++ PATCH for c++/78010 - bogus -Wsuggest-override warning on final function
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]