This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ Patch] Avoid some duplicate error messages
- From: Jason Merrill <jason at redhat dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 10 May 2019 10:44:17 -0400
- Subject: Re: [C++ Patch] Avoid some duplicate error messages
- References: <03cd0dbc-6e5e-a643-5618-a7b94379298a@oracle.com>
On 4/29/19 2:50 PM, Paolo Carlini wrote:
Hi,
I have a small back queue of tweaks of various kinds and sizes, this one
seems small enough to be safe wrt last minute release branch fixes.
While working on the regression c++/88969, some duplicate errors showed
up when we started giving appropriate diagnostics instead of ICEing,
which could be cured by unconditionally returning error_mark_node from
cp_build_function_call_vec when mark_used fails. In general, in the
front-end we have a mix of unconditional and conditional to SFINAE
context mark_used checks, I think it's often a delicate choice, the
below change passes testing, I would give it a spin, at the beginning of
Stage1. Tested x86_64-linux.
OK.
Jason