This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] RX: Add rx-*-linux target
- From: Yoshinori Sato <ysato at users dot sourceforge dot jp>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 01 May 2019 22:12:25 +0900
- Subject: Re: [PATCH] RX: Add rx-*-linux target
- References: <87tvfp7m40.wl-ysato@users.sourceforge.jp> <438ce60e-3ace-5fc9-9751-b53c8229cd2e@redhat.com> <87bm0nsil4.wl-ysato@users.sourceforge.jp> <c8dfbb70-a744-b484-e8c6-e7338f3c50c1@redhat.com>
On Wed, 01 May 2019 00:37:56 +0900,
Jeff Law wrote:
>
> On 4/30/19 7:55 AM, Yoshinori Sato wrote:
> > On Tue, 30 Apr 2019 06:48:01 +0900,
> > Jeff Law wrote:
> >>
> >> On 3/26/19 8:21 AM, Yoshinori Sato wrote:
> >>> I ported linux kernel to Renesas RX.
> >>>
> >>> rx-*-elf target output a binary different from the standard ELF.
> >>> It has the same format as the Renesas compiler.
> >>>
> >>> But the linux kernel requires the standard ELF format.
> >>> I want to define a rx-*-linux target so that I can generate
> >>> a standard ELF binary.I believe you have a copyright assignment on file for your H8 work. Was
> >> the assignment specific to the H8 or was it more general?
> >
> > No. This changes other target.
> > These files are not included in my copyright assignment.
> >
> >>
> >>> diff --git a/gcc/config/rx/linux.h b/gcc/config/rx/linux.h
> >>> new file mode 100644
> >>> index 00000000000..69500a379f2
> >>> --- /dev/null
> >>> +++ b/gcc/config/rx/linux.h
> >>
> >>> +
> >>> +/* This is how to output an element of a case-vector that is relative.
> >>> + Note: The local label referenced by the "3b" below is emitted by
> >>> + the tablejump insn. */
> >>> +
> >>> +#undef ASM_OUTPUT_ADDR_DIFF_ELT
> >>> +#define ASM_OUTPUT_ADDR_DIFF_ELT(FILE, BODY, VALUE, REL) \
> >>> + fprintf (FILE, "\t.long .L%d - 1b\n", VALUE)
> >> Note the comment references "3b", but the output is "1b".
> >
> > Oh.
> > I will update it.
> >
> >> I don't see anything in here significantly concerning. We just need to
> >> verify your copyright assignment status.
> >
> > OK.
> >
> >> Also, do you have write access to the repo?
> >
> > I don't have write permission of svn repository.
> OK. So let me know when the assignment is updated and I'll commit the
> changes.
>
> If you forsee doing future work, you might consider a broader assignment
> so that we don't have to go through the assignment process for each
> contribution.
>
> Jeff
Thank you.
When the procedure is over, post a patch that corrects the comment.
--
Yosinori Sato