This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] Fix multiple values for -fdbg-cnt.


On Thu, Mar 28, 2019 at 2:05 PM Martin Liška <mliska@suse.cz> wrote:
>
> On 3/28/19 1:51 PM, Richard Biener wrote:
> > On Wed, Mar 27, 2019 at 10:52 AM marxin <mliska@suse.cz> wrote:
> >>
> >>
> >> gcc/ChangeLog:
> >>
> >> 2019-03-27  Martin Liska  <mliska@suse.cz>
> >>
> >>         * dbgcnt.c (dbg_cnt_process_single_pair): Fix GNU coding style.
> >>         (dbg_cnt_process_opt): Parse first tokens aas
> >
> > as
>
> Better than 'ass' :)
>
> >
> > so what was the issue you fixed?
>
> $ gcc -c -fdbg-cnt=dce:0,vect_slp:3 main.c
> dbg_cnt 'dce' set to 0-3
>
> while correct output is:
>
> $ gcc-8 -c -fdbg-cnt=dce:0,vect_slp:3 main.c
> dbg_cnt 'dce' set to 0
> dbg_cnt 'vect_slp' set to 3

Ah.

OK.
Richard.

> Martin
>
> >
> >>         dbg_cnt_process_single_pair is also using strtok.
> >> ---
> >>  gcc/dbgcnt.c | 25 +++++++++++++++----------
> >>  1 file changed, 15 insertions(+), 10 deletions(-)
> >>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]