This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Bug85667-(x86_64) ms_abi rules aren't followed when returning short structs with float values(32-bit)
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: Lokesh Janghel <lokeshjanghel91 at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, mateuszb at poczta dot onet dot pl, Jakub Jelinek <jakub at redhat dot com>
- Date: Wed, 27 Mar 2019 20:23:55 +0100
- Subject: Re: [Patch] Bug85667-(x86_64) ms_abi rules aren't followed when returning short structs with float values(32-bit)
- References: <CACcU4_pGzr8aw-Y5U=TtDzDSn2yb419Fv7-pEYceecCOvpf3gw@mail.gmail.com> <4851044.6TxkZdENuJ@polaris> <CACcU4_pKBp38mKuFkXiRNy6abp=ekiKp6r1O_i8NKtEAVe_c_A@mail.gmail.com> <1648188.CfadMSqW0T@arcturus.home>
On Wed, Mar 27, 2019 at 3:08 PM Eric Botcazou <ebotcazou@adacore.com> wrote:
>
> > I modified the patch.
> > Please let me know your thoughts.
>
> Thanks. This version is certainly better, but I cannot approve it myself.
>
> Uros, given that the bug was fixed in 64-bit mode for GCC 9, I think that it
> would make sense to have it fixed in 32-bit mode too.
I would really like for MS_ABI maintainer to approve the patch, but
this particular patch looks straightforward, so I'll approve it
myself.
So, OK for mainline and eventual backporting to release branches.
Thanks,
Uros.