This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] make ggc pick up comp_dir_string() cache value. (dwarf2out.c)


On Mon, Mar 25, 2019 at 1:25 PM Richard Biener
<richard.guenther@gmail.com> wrote:
>
> On Fri, Mar 22, 2019 at 10:22 AM Otto, Thomas <thomas.otto@pdv-fs.de> wrote:
> >
> > > > And I still think this function and the static variable which never changes
> > > > once set does not require any GC. Just setting the cached_wd variable to
> > > > the unchanged pointer from get_src_pwd() or allocating one in the function
> > > > itself is enough. This solves the problem and relieves the GC from the task of
> > > > watching over a variable which lives forever anyhow.
> > >
> > > Yes, that works as well then.
> >
> > Ok, see the attached patch.
>
> Thanks - I suppose you do not have SVN write access.  I'll properly test and
> commit the patch for you.

r269916 on trunk (GCC 9).

Richard.

> Richard.
>
> > Regards,
> >
> > Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]