This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] Fix PR 78865, ICE on invalid
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Thomas Koenig <tkoenig at netcologne dot de>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 24 Mar 2019 10:29:57 +0000
- Subject: Re: [patch, fortran] Fix PR 78865, ICE on invalid
- References: <b83020d6-9266-dec1-5c49-cdd555f7721c@netcologne.de>
Hi Thomas,
This is OK for trunk and, after a wee delay for the other active branches.
Thanks
Paul
On Fri, 22 Mar 2019 at 22:56, Thomas Koenig <tkoenig@netcologne.de> wrote:
>
> Hello world,
>
> the attached patch fixes a 7/8/9 regression. The problem was twofold:
> If a subroutine was called more than once from a different subroutine,
> the call was only checked the first time. Also, a type change in the
> backend_decl initiated when there was already a declaration led to an
> ICE.
>
> The solution also has two parts: Make sure that a hard error is
> delivered in this case, and make sure the check is done every time.
>
> Regression-tested. OK for trunk and other affected branches?
>
> Regards
>
> Thomas
>
> 2019-03-22 Thomas Koenig <tkoenig@gcc.gnu.org>
>
> PR fortran/78865
> * interface.c (compare_actual_formal): Change errors about
> missing or extra to gfc_error_now to make sure they are issued.
> Change "spec" to "specifier" in message.
> * resolve.c (resolve_global_procedure): Also check for mismatching
> interface with global symbols if the namespace has already been
> resolved.
>
> 2019-03-22 Thomas Koenig <tkoenig@gcc.gnu.org>
>
> PR fortran/78865
> * gfortran.dg/altreturn_10.f90: New test.
> * gfortran.dg/whole_file_3.f90: Change dg-warning to dg-error.
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein