Re: [C++ PATCH] Fix lambda capture duplicate handling (PR c++/89767, take 3 & 4)

[Nathan Sidwell <nathan at acm dot org>]

On 3/20/19 1:15 PM, Jakub Jelinek wrote:
> On Wed, Mar 20, 2019 at 11:10:19AM -0400, Nathan Sidwell wrote:
> > I was unclear.  I was for the lazy creation of the hash.  I just think it
> > can be lazily created at either the first or second explicit capture.
>
> On top of the https://gcc.gnu.org/ml/gcc-patches/2019-03/msg00991.html
> patch I've just posted here are two different patches to do this, the
> first one optimizes just the zero captures case and creates a hash_set
> on the first add_capture, the second one optimizes zero and one captures
> case and creates a hash_set on the second add_capture.

Thanks.  Looking at the 8 or so lines in the second patch dealing with 
the single case I can't help thinking that's not an optimization.  I 
suppose the initial calloc could be pricy.

But anyway, overthinking this.  Either patch is fine -- you choose!

nathan

--
Nathan Sidwell