This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix RTL loop-unroll ICE (PR rtl-optimization/89768)
- From: Jeff Law <law at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <rguenther at suse dot de>, Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 19 Mar 2019 13:47:52 -0600
- Subject: Re: [PATCH] Fix RTL loop-unroll ICE (PR rtl-optimization/89768)
- References: <20190319175433.GF7611@tucnak>
On 3/19/19 11:54 AM, Jakub Jelinek wrote:
> Hi!
>
> On the testcase in the PR we ICE because we create non-canonical CONST_INTs
> (e.g. for HImode niter 0xfffe) and the compare_and_jump_seq code then ICEs
> on that.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
>
> Testcase not included, because it creates 480000 basic blocks and we handle
> that with O(n^2) complexity.
>
> 2019-03-19 Jakub Jelinek <jakub@redhat.com>
>
> PR rtl-optimization/89768
> * loop-unroll.c (unroll_loop_constant_iterations): Use gen_int_mode
> instead of GEN_INT.
> (unroll_loop_runtime_iterations): Likewise.
OK
jeff