This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: V2 [PATCH] i386: Handle REG_EH_REGION note
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, Jan Hubicka <hubicka at ucw dot cz>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Hongtao Liu <crazylht at gmail dot com>
- Date: Thu, 14 Mar 2019 16:46:58 +0800
- Subject: Re: V2 [PATCH] i386: Handle REG_EH_REGION note
- References: <20190312013632.GA30916@gmail.com> <20190313172844.GK7611@tucnak> <CAMe9rOoAjqMO-dxOhhrZDBnck2c-CaJZBoLbjseVMYHRV7r1HA@mail.gmail.com> <20190314083435.GR7611@tucnak>
On Thu, Mar 14, 2019 at 4:34 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Thu, Mar 14, 2019 at 11:30:21AM +0800, H.J. Lu wrote:
> > We need to split the basic block if we create new insns, which may
> > throw exceptions, in the middle of the basic blocks.
> >
> > Tested on AVX2 and AVX512 machines with and without
> >
> > --with-arch=native
> >
> > OK for trunk?
>
> That looks much better, I see you chose to follow what lower-subreg.c does
> here. I just wonder if instead of the sbitmap of blocks to check for splitting it
> wouldn't be more efficient to have an auto_vec<rtx_insn *> holding the exact
> set_insns that need splitting after them and just grab the bb using
> BLOCK_FOR_INSN.
>
Good idea. I will work on it.
Thanks.
--
H.J.