Re: [PR 87525] Zero local estimated benefit for cloning extern inline function

[Jan Hubicka <jh at suse dot de>]

Dne 2019-02-27 13:00, Martin Jambor napsal:
> Hi,
>
> in the discussion in PR 87525 Honza noted that IPA-CP should not
> estimate any local time benefits from cloning an extern inline 
> function,
> that any benefits this might bring about have to come from other
> specializations such cloning might enable.
>
> While the patch is only a heuristics change and so does not really fix
> the issue (which itself is a part of more general set of problems with
> -D_FORTIFY_SOURCE and LTO), it should make it much less likely and is
> sensible change on its own.
>
> Bootstrapped and tested on x86_54-linux, OK for trunk and the
> gcc-8-branch?
>
> Thanks,
>
> Martin
>
>
>
>
> 2019-02-25  Martin Jambor  <mjambor@suse.cz>
>
> 	PR lto/87525
> 	* ipa-cp.c (perform_estimation_of_a_value): Account zero time benefit
> 	for extern inline functions.
>
> 	testsuite/
> 	* gcc.dg/ipa/ipcp-5.c: New test.

OK,
please wait a week before backporting to gcc 8. I believe gcc 7 suffers 
from
same issue so backporting there makes sense too.

Honza