This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fortran/88342 -- interaction of -ffpe-trap and IEEE_VALUE


On Sun, Dec 30, 2018 at 09:32:43AM -0800, H.J. Lu wrote:
> On Sun, Dec 30, 2018 at 9:09 AM Steve Kargl
> <sgk@troutmask.apl.washington.edu> wrote:
> >
> > On Sun, Dec 30, 2018 at 08:06:40AM -0800, H.J. Lu wrote:
> > > >
> > > > OK Steve, thanks.
> > >
> > > The test fails on Linux/x86:
> > >
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88639
> > >
> >
> > The test works on both i586-*-freebsd and x86_64-*-freebsd.
> > What does
> >
> 
> diff --git a/gcc/testsuite/gfortran.dg/ieee/ieee_10.f90
> b/gcc/testsuite/gfortran.dg/ieee/ieee_10.f90
> index 9eb4620f0f9..c3ffffcb24d 100644
> --- a/gcc/testsuite/gfortran.dg/ieee/ieee_10.f90
> +++ b/gcc/testsuite/gfortran.dg/ieee/ieee_10.f90
> @@ -1,5 +1,8 @@
>  ! { dg-do run }
> -! { dg-options "-ffpe-trap=overflow,invalid" }
> +! { dg-additional-options "-ffpe-trap=overflow,invalid" }
> +!
> +! Use dg-additional-options rather than dg-options to avoid overwriting the
> +! default IEEE options which are passed by ieee.exp and necessary.
> 
> I am checking in this patch as an obvious fix.
> 

Thanks for the fix and sorry about the breakage.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]