This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix hashtable node deallocation
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 21 Dec 2018 20:29:04 +0000
- Subject: Re: Fix hashtable node deallocation
- References: <ad43e63d-3626-116e-d34e-dde6d4e708c9@gmail.com> <20181119123417.GS28365@redhat.com> <ec8960df-a59e-3e3e-f67c-2a4247b12a20@gmail.com> <6b612320-6ff5-a3bf-692d-f6f0775e4219@gmail.com> <eaec750c-8c05-d76a-22f9-76307993feab@gmail.com>
On 16/12/18 14:16 +0100, François Dumont wrote:
Gentle reminder, we still have this issue pending.
* include/bits/hashtable_policy.h
(_Hashtable_alloc<>::_M_deallocate_node_ptr(__node_type*)): New.
(_Hashtable_alloc<>::_M_deallocate_node(__node_type*)): Use latter.
(_ReuseOrAllocNode<>::operator<_Arg>()(_Arg&&)): Likewise.
Please add more detail to the commit message explaining the problem.
Either as a paragraph of text in the commit message before the
changelog (e.g. see https://gcc.gnu.org/r267236 or
https://gcc.gnu.org/r267276 for commits with additional text in the
commit message), or in the changelog itself, e.g.
(_ReuseOrAllocNode<>::operator<_Arg>()(_Arg&&)): Likewise, so
that the argument to __node_alloc_traits::deallocate is the
correct pointer type.
* libstdc++-v3/testsuite/util/testsuite_allocator.h
(CustomPointerAlloc<>::allocate(size_t, pointer)): Replace by...
(CustomPointerAlloc<>::allocate(size_t, const_void_pointer)): ...this.
This should have been a separate commit really.
OK for trunk with a better commit message that explains what the
change does.