This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch,openacc] Fix PR71959: lto dump of callee counts
- From: Julian Brown <julian at codesourcery dot com>
- To: Martin Jambor <mjambor at suse dot cz>
- Cc: Cesar Philippidis <cesar at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 21 Dec 2018 02:56:36 +0000
- Subject: Re: [patch,openacc] Fix PR71959: lto dump of callee counts
- References: <319b3ebd-c601-449b-718c-963b68414224@codesourcery.com> <ri6in2thgwp.fsf@suse.cz>
On Tue, 25 Sep 2018 14:59:18 +0200
Martin Jambor <mjambor@suse.cz> wrote:
> Hi,
>
> I have noticed a few things...
>
> On Thu, Sep 20 2018, Cesar Philippidis wrote:
> > This is another old gomp4 patch that demotes an ICE in PR71959 to a
> > linker warning. One problem here is that it is not clear if OpenACC
> > allows individual member functions in C++ classes to be marked as
> > acc routines. There's another issue accessing member data inside
> > offloaded regions. We'll add some support for member data OpenACC
> > 2.6, but some of the OpenACC C++ semantics are still unclear.
> >
> > Is this OK for trunk? I bootstrapped and regtested it for x86_64
> > Linux with nvptx offloading.
> [...]
The testcase associated with this bug appears to be fixed by the
following patch:
https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01167.html
So, it's unclear if there's anything left to do here, and this patch
can probably be withdrawn.
Thanks,
Julian